fix: improve tcsh completion support#9503
Draft
ThomasWaldmann wants to merge 1 commit intoborgbackup:masterfrom
Draft
fix: improve tcsh completion support#9503ThomasWaldmann wants to merge 1 commit intoborgbackup:masterfrom
ThomasWaldmann wants to merge 1 commit intoborgbackup:masterfrom
Conversation
This commit fixes critical evaluation crashes in the generated tcsh completion script and significantly cleans up the Python generation logic: - monkeypatch shtab to natively support positional completion under subcommands for tcsh (e.g., `borg help <topic>`). - fix "if: Empty if." errors in tcsh by injecting array bounds checks (`$#cmd >= max_idx`) inside the monkeypatched shtab generator. - fix recursive parser crashes in tcsh by replacing unescaped nested backticks (`...`) with safe `eval` evaluations. - deduplicate tcsh fallback rules to reduce the script payload size, preventing tcsh memory buffer truncations that led to cryptic "Illegal variable name." exceptions. - no support yet for archive, aid:, and tags completion features for tcsh
Member
Author
|
This was created with AI assistance (Gemini Flash/Pro) and likely needs more work:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9503 +/- ##
==========================================
+ Coverage 83.36% 83.40% +0.04%
==========================================
Files 87 87
Lines 15439 15523 +84
Branches 2309 2336 +27
==========================================
+ Hits 12870 12947 +77
- Misses 1818 1821 +3
- Partials 751 755 +4 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@simaoafonso-pwt Could you have a look at that monkeypatch please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes critical evaluation crashes in the generated tcsh completion script and significantly cleans up the Python generation logic:
borg help <topic>).$#cmd >= max_idx) inside the monkeypatched shtab generator....) with safeevalevaluations.Description
Checklist
master(or maintenance branch if only applicable there)toxor the relevant test subset)